fix(frontend): pass fill-type separately instead of baking it into icon names - #15
Merged
Conversation
…on names
Every oc-icon usage passed names like 'chat-3-line' or 'close-line' directly as
the `name` prop, but design-system's OcIcon builds the asset path as
`${name}-${fillType}.svg` with fillType defaulting to 'fill'. That produced
malformed, nonexistent paths (e.g. 'chat-3-line-fill.svg'), so every node card
and panel icon silently fell back to OcIcon's default 'info' icon instead of
its intended one.
Strip the baked-in '-line' suffix from every icon name (in nodeTypes.ts and
the few hardcoded ones) and pass fill-type="line" explicitly, matching the
convention used elsewhere in ownCloud Web.
Signed-off-by: Lukas Hirt <info@hirt.cz>
mzner
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<oc-icon>usage across the workflow builder (node cards, node picker, details panel, executions panel, back button) passed the icon name with the style baked in, e.g.chat-3-line,close-line,play-circle-line.OcIcon(design-system, provided by the oCIS Web host at runtime) builds the SVG asset path as${name}-${fillType}.svg, withfillTypedefaulting to'fill'when not passed. That produced nonexistent paths likechat-3-line-fill.svg, which 404'd — so every one of these icons silently renderedOcIcon's hardcodedinfofallback instead of the intended icon.-linesuffix from every icon name (frontend/src/nodeTypes.tsand the few hardcoded fallbacks inTriggerNode.vue/ActionNode.vue/WorkflowBuilder.vue/panels) and passfill-type="line"explicitly on each<oc-icon>, matching the convention used elsewhere in ownCloud Web (e.g.CreateLinkModal.vue,SideBar.vue).Test plan
pnpm exec vue-tsc --noEmitpassespnpm test:unit runpasses (4/4)