refactor: [DC-349] allow user to set an alias for account - #12639
Merged
Conversation
not yet editable. is represented in config already in most basic form.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
modSpike
marked this pull request as draft
September 7, 2026 15:53
the toolbar apparently ignores min size hint on the toolbar buttons so my default alias "Lisa" leaves us with a very narrow button that looks quite bad. So I applied a minumum width using the silver ratio against the min size hint height. This looks a lot better. Also decided to hide the separator before the more button as the extra spacing around it makes the more button look subtly weird. I'm not applying a max width as I don't like the effect on eg long aliases and could definitely be a problem on "long" translation texts.
it pops a dialog to enter the new alias.
removed AccountManager as friend and updated accordingly also killed the qml related QProperties folder wizard still works fine so confirmed these props are no longer needed.
modSpike
marked this pull request as ready for review
September 8, 2026 11:15
modSpike
enabled auto-merge (squash)
September 8, 2026 11:29
modSpike
disabled auto-merge
September 8, 2026 11:29
modSpike
enabled auto-merge (squash)
September 8, 2026 11:40
erikjv
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-349