chore: bump the Rust toolchain to 1.98.1 and trim AGENTS.md - #428
Merged
Conversation
The MSRV moves to `Cargo.toml`'s `rust-version`, which Clippy reads natively, so `clippy.toml`'s `msrv` key goes. That also makes it a cargo-enforced floor for `cargo install` and sdist builds, which the README now states. 1.98's new `chunks_exact_to_as_chunks` fires at three sites; `as_chunks::<N>()` yields arrays, so the byte-by-byte rebuilds go with it. AGENTS.md loses the three Rust bullets external skills now own, and `[lints.rust] unsafe_code = "forbid"` replaces the deleted no-unsafe prose, reaching the test targets the crate-root attributes never covered. Closes #426, closes #427 Claude-Session: https://claude.ai/code/session_01L2XE37GUJWcHp7hPKMdHU8
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Deploying ryl-docs with
|
| Latest commit: |
7b3e213
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0619b870.ryl-docs.pages.dev |
| Branch Preview URL: | https://toolchain-1-98-1.ryl-docs.pages.dev |
Test Coverage (nextest + cargo-llvm-cov)Missed Lines (per file) |
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
rust-toolchain.tomlto 1.98.1; the MSRV moves toCargo.toml'srust-version, soclippy.toml'smsrvgoes.clippy::chunks_exact_to_as_chunksfires at three sites;as_chunks::<N>()replaces them, dropping the byte-by-byte rebuilds.
AGENTS.mdloses the three Rust bullets;[lints.rust] unsafe_code = "forbid"replacesthe deleted no-unsafe prose and reaches the test targets too.
Departures from the issues
rust-versionis cargo-enforced, not just a Clippy hint:cargo +1.97.1 checknowhard-fails. Kept at 1.98.1 to match the pin, with the README stating it.
named here. Dropped: this repo is public, the skills repo is not.
Notes for the reviewer
Nothing in #426's feature delta was worth
adopting:
substr_rangehas no site here, and
from_utf16le/bechanges error text thedecodertests assertinvalid utf-16prefix, which survives; only the detail text changes. The
as_chunksrewrite was checked differentially against thepre-change binary over 99 encoding fixtures, not by reading.
Skills used
pr-reviewrust-code-styledocssoftware-engineeringCloses #426, closes #427
— Claude