fix(lsp): long-poll workspace/diagnostic instead of answering idle pulls - #424
Merged
Conversation
Result ids let an unchanged file answer `unchanged`; an all-unchanged report is held open and resumed on the next state change, so an idle workspace costs nothing. A `partialResultToken` streams changed files as `$/progress` batches. Bumps to 0.22.0. Claude-Session: https://claude.ai/code/session_01L2XE37GUJWcHp7hPKMdHU8
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Deploying ryl-docs with
|
| Latest commit: |
66983fb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f0732c15.ryl-docs.pages.dev |
| Branch Preview URL: | https://408-longpoll-workspace-diagn.ryl-docs.pages.dev |
Test Coverage (nextest + cargo-llvm-cov)Missed Lines (per file) |
`says_nothing` already returns false once anything has streamed, so the extra `streamed ||` in `scan_answer` read as an independent condition it was not. The sink's final flush only ran when a batch happened not to have flushed on the timer, so a deleted-file test now pins it deterministically. Claude-Session: https://claude.ai/code/session_01L2XE37GUJWcHp7hPKMdHU8
An audit of every comment the branch adds, against this repo's "comments earn their place" bar: seven doc comments restated their own signature or duplicated the type's doc, and two test comments duplicated their assertion message. The rest are why-comments the code cannot convey on its own. Claude-Session: https://claude.ai/code/session_01L2XE37GUJWcHp7hPKMdHU8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vscode-languageclientre-issuesworkspace/diagnostica fixed 2 s after every response,with no client-side knob, and ryl answered each one with a full walk and lint of every YAML
file. Closes #408. Bumped to 0.22.0 with a refreshed benchmark chart.
What changed
result_ids, so an unchanged file answersunchanged. When every filewould, the pull is not answered: it is held open and resumed by the next edit,
watched-file or config change.
partialResultTokenstreams changed files as$/progressbatches;unchangedonescome back in the response.
Where to focus review
**/*.{yaml,yml}as well as config names, so agit checkoutcanwake a held pull rather than leaving the Problems panel stale.
ty behaves the same; worth confirming with the reporter after release.
Skills used
docspr-reviewreleasesoftware-engineering— Claude
https://claude.ai/code/session_01L2XE37GUJWcHp7hPKMdHU8