chore(deps): bump lsp-server to 0.10.0 and jsonschema to 0.52.1 - #421
Merged
Conversation
lsp-server 0.10 folds `Response::result` and `Response::error` into one `response_result: Result<Value, ResponseError>` field, so the LSP test suites now read that field. jsonschema is a dev-only dependency and the `validator_for` API ryl's tests use is unchanged across 0.47 to 0.52. Supersedes #418. Co-Authored-By: Claude <noreply@anthropic.com>
Deploying ryl-docs with
|
| Latest commit: |
6a48120
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9b88bcb2.ryl-docs.pages.dev |
| Branch Preview URL: | https://chore-bump-lsp-server-0-10-j.ryl-docs.pages.dev |
Test Coverage (nextest + cargo-llvm-cov)Missed Lines (per file) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Dependabot's #418, whose branch is stale and fails to compile against lsp-server 0.10.
What changed
lsp-server0.8.0 to 0.10.0 (runtime, behind thelspfeature, and dev). 0.10 foldsResponse::resultandResponse::errorinto oneresponse_result: Result<Value, ResponseError>field. Only the three LSP test suites read those fields, so they now readresponse_result;src/lsponly builds responses throughResponse::new_ok/new_err, which are unchanged.jsonschema0.46.2 to 0.52.1 (dev-only). Dependabot targeted 0.49.9, but 0.52.1 is current and thevalidator_forAPI the tests use is unchanged across 0.47 to 0.52. The one breaking note in that range concernsdefault-features = false, which ryl does not set.Why
#418 has been stuck since 21 Aug: its workflow-file hunks now conflict with #420 and its tests no longer compile. A fresh branch off main is simpler than repairing it.
Risk
Low. No
src/changes. Full suite passes locally (1749 tests),prek run --all-filesis clean, both-D warningsclippy gates pass, and the coverage script reports no uncovered regions.cargo auditis clean on the new lock.Where to focus review
tests/lsp_server.rsaround the formerassert_eq!(response.result, Some(Value::Null))sites, nowmatches!(response.response_result, Ok(Value::Null)), and the cancelledworkspace/diagnostictest whose old assertion became vacuous under the new type and now checks the response id instead.Skills used
human-collaboration