test: Refactor disconnect handling integration tests#424
Open
dave-tucker wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
EDIT: It was pointed out to me that: This PR is now just the test refactor. |
dave-tucker
changed the title
Merged
dave-tucker
force-pushed
the
timeout
branch
4 times, most recently
from
March 2, 2026 16:01
494d7b8 to
7ae7af0
Compare
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
The TestWithInactivity and TestWithReconnect logic is pretty much identical. Move the common code into testReconnect. This also removes the 2 ovsClients. Only a single client is used now. A test may change the options at the beginning of the test. Adds a TestWithFastInactivity variant with an aggressive timer to try and reproduce ovn-kubernetes#391. This also fixes data races in the MonitorCondition tests. In addition, migrates from dockertest to testcontainers. The former had issues running using Podman Desktop on macOS. The latter is much more stable. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRY up the disconnect handling test logic.
Fix a data race in the MonitorCondition tests.