ovsdb: don't create sized arrays for OVS Sets#347
Merged
Conversation
Pull Request Test Coverage Report for Build 3930363015
💛 - Coveralls |
|
This looks good to me Jaime. We've run into this issue as well. Would be great to get it merged! |
Contributor
|
@jcaamano want to grab ovn-org@a4ac416 here? It's rebased on current main. |
OVS Sets must be unique, but modelgen created sized arrays
to represent OVS Sets, which when marshalled are filled with
duplicate default values.
For a column schema like:
"cvlans": {
"type": {"key": {"type": "integer",
"minInteger": 0,
"maxInteger": 4095},
"min": 0, "max": 4096}},
modelgen would create:
CVLANs [4096]int
which when marshalled and sent to ovsdb-server becomes:
cvlans:{GoSet:[0 0 0 0 0 0 0 <repeat many times>]}
and is rejected by ovsdb-server with:
{Count:0 Error:ovsdb error Details:set contains duplicate UUID:{GoUUID:} Rows:[]}] and errors [ovsdb error: set contains duplicate]: 1 ovsdb operations failed
Instead, generate these fields as slices instead of sized
arrays.
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Co-authored-by: Dan Williams dcbw@redhat.com
Contributor
|
LGTM, I'll follow up some validation and cleanups https://github.com/ovn-org/libovsdb/pull/333 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OVS Sets must be unique, but modelgen created sized arrays to represent OVS Sets, which when marshalled are filled with duplicate default values.
For a column schema like:
"cvlans": {
"type": {"key": {"type": "integer",
"minInteger": 0,
"maxInteger": 4095},
"min": 0, "max": 4096}},
modelgen would create:
CVLANs [4096]int
which when marshalled and sent to ovsdb-server becomes:
cvlans:{GoSet:[0 0 0 0 0 0 0 ]}
and is rejected by ovsdb-server with:
{Count:0 Error:ovsdb error Details:set contains duplicate UUID:{GoUUID:} Rows:[]}] and errors [ovsdb error: set contains duplicate]: 1 ovsdb operations failed
Instead, generate these fields as slices instead of sized arrays and enforce the size when marshalling the set.
Signed-off-by: Jaime Caamaño Ruiz jcaamano@redhat.com
Co-authored-by: Dan Williams dcbw@redhat.com