server: implement column filters in Select()#289
Open
dcbw wants to merge 1 commit into
Open
Conversation
Collaborator
|
Just a heads up on the different behavior of including empty columns whether they were requested or not. If no columns were requested, empty columns are not included. For requested columns, empty columns are included. The RFC is not really explicit about it Should we check what the ovs ovsdb server does? |
Since the unit test for Monitor() requests all columns, we now have to expect empty fields for those columns in the response. Previously Select() just ignored the columns that Monitor() requested and thus elided empty columns from the result. Signed-off-by: Dan Williams <dcbw@redhat.com>
Pull Request Test Coverage Report for Build 1773018781
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the unit test for Monitor() requests all columns,
we now have to expect empty fields for those columns in
the response.
Previously Select() just ignored the columns that
Monitor() requested and thus elided empty columns from
the result.
@trozet @dave-tucker @jcaamano