Skip to content

Add opentelemetry support#189

Open
dave-tucker wants to merge 1 commit into
ovn-kubernetes:mainfrom
dave-tucker:otel
Open

Add opentelemetry support#189
dave-tucker wants to merge 1 commit into
ovn-kubernetes:mainfrom
dave-tucker:otel

Conversation

@dave-tucker

@dave-tucker dave-tucker commented Jul 9, 2021

Copy link
Copy Markdown
Collaborator
  1. Added context.Context to most API methods for span propagation
  2. Spans are added to the parent (from context) when an API is called
  3. Simple cache metrics can be registered with cache.RegisterMetrics()
  4. Adds Docker Images for stress, print-schema and modelgen

Fixes: #146

Signed-off-by: Dave Tucker dave@dtucker.co.uk

@dave-tucker dave-tucker added this to the Future milestone Jul 9, 2021
@coveralls

coveralls commented Jul 9, 2021

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1333194463

  • 106 of 132 (80.3%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 73.185%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/transact.go 34 35 97.14%
client/client.go 23 26 88.46%
server/server.go 16 20 80.0%
cache/cache.go 10 28 35.71%
Files with Coverage Reduction New Missed Lines %
client/client.go 1 69.72%
Totals Coverage Status
Change from base Build 1321747633: 0.4%
Covered Lines: 4001
Relevant Lines: 5467

💛 - Coveralls

@dave-tucker
dave-tucker force-pushed the otel branch 2 times, most recently from af79796 to 0850976 Compare July 9, 2021 16:49
@dave-tucker dave-tucker modified the milestones: Future, 0.7.0 Jul 9, 2021
@dave-tucker
dave-tucker force-pushed the otel branch 3 times, most recently from 3125ccd to d86efbe Compare July 15, 2021 17:39
1. Added context.Context to most API methods for span propagation
2. Spans are added to the parent (from context) when an API is called
3. Simple cache metrics can be registered with cache.RegisterMetrics()

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenTelemetry Support

2 participants