Validate presets against simdata configuration#1251
Open
ezio-melotti wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds validation functionality to ensure that cached simulation data configurations match their corresponding preset definitions. After downloading cached simdata for a preset simulation, the new validation function compares the configuration values and logs any discrepancies to the console.
Key Changes
- Added
validateSimdataConfigurationmethod to compare preset and simdata configurations - Integrated validation into the preset data import flow to detect configuration mismatches
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a function that validates simdata configuration against the presets to ensure that they match. This is done after launching a preset simulation and downloading the cached simdata.