Add a systemd env file that defines runtime variables#397
Open
ezio-melotti wants to merge 7 commits into
Open
Conversation
ezio-melotti
added
systemd
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a generated environment file (.env) intended for use by systemd units, so runtime-configurable values (starting with VENV_PY) can be injected without hardcoding them directly in each service unit.
Changes:
- Add
write_service_env_file()to generatesimoc-sam/.envand call it duringupdate()andsetup_systemd_unit(). - Update multiple
configs/*.serviceunit files to readVENV_PYfromEnvironmentFile=and use it inExecStart=. - Add
.envto.gitignore.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
simoc-sam.py |
Adds .env generation and hooks it into update/unit setup flows. |
configs/sqlwriter.service |
Switches Python executable to ${VENV_PY} loaded from .env. |
configs/siobridge.service |
Switches Python executable to ${VENV_PY} loaded from .env. |
configs/sensor-runner@.service |
Switches Python executable to ${VENV_PY} loaded from .env. |
configs/display-runner@.service |
Switches Python executable to ${VENV_PY} loaded from .env. |
configs/csvwriter.service |
Switches Python executable to ${VENV_PY} loaded from .env. |
.gitignore |
Ignores the generated .env file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an environment file which contains runtime variables to be used by systemd services, as described in:
Currently it only defines the
VENV_PYvariable, but by introducing the.envfile and adding it to the services units, it allows us to easily inject more variables when needed. The username and working dir are still hardcoded, but that can be fixed in a separate PR.