Sentry reporting - #2382
Open
vatral wants to merge 29 commits into
Open
Conversation
Works, but still needs settings, more data, a bit of refactoring, etc
This is the start of a plan to refactor the API to better fit the features Sentry Native exposes. If we want to bring back Crashpad and Breakpad later, they should be adapted to the new API. It appears that we can also do cleaner exception handling based on the API docs, so that's removed here as well.
Add log streaming and stats submission
Generates a random but easily pronounceable tag that can be used to pass to a developer, to let them easily locate a matching report in the Sentry (or similar) database.
Avoid discarding reports
Since the current version of Sentry Native is too old, contexts have to be manually merged. This could be removed after an upgrade
Make it correctly persist. There was a bit of a snag between the menu system and the crash specific setting. Make it all use the same setting keys.
We've discussed redoing the menu system, so this is probably better addressed at that point in time or at least as a separate PR.
JulianGro
added a commit
to JulianGro/overte
that referenced
this pull request
Aug 10, 2026
added 5 commits
August 10, 2026 19:15
Also remove old unused code
Add support tag to about screen
vatral
marked this pull request as ready for review
August 10, 2026 19:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Julian's PR.
This was an extensive refactor that removed most of the old code, as well as support for Breakpad and Crashpad. Those can come back if they're wanted, but were removed because I saw that Sentry's capabilities needed a bit of accommodation, and we're probably sticking with Sentry anyway.
The crash handler is opt-in. On crash you'll get the "reset settings?" screen, with the crash handler settings right there. They're also in the Developer/Network menu.
Functionality:
CrashHandlerobject. Read-only.Removed functionality:
TODO:
I'm going on a long trip starting tomorrow, so time to do further work on this will likely be scarce. If something is not right, help would be very welcome.