Remove MAC address handling and system info JSON - #2378
Open
ada-tv wants to merge 1 commit into
Open
Conversation
ada-tv
added
needs CR
vatral
approved these changes
Aug 8, 2026
vatral
left a comment
vatral
left a comment
Contributor
There was a problem hiding this comment.
Looks good, yeah, given the machine fingerprint the MAC is redundant anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plaintext MAC addresses aren't necessary, since we already have hashed machine IDs.
The system info JSON was basically useless and was only logged by
domain-server.There should be a follow-up protocol breaking PR to remove the now empty
hardwareAddressandsystemInfofields from the domain server handshake packet when we have the chance.