Revert improved culling frustum in OpenVR. - #2375
Merged
Merged
Conversation
Fixes overte-org#2242 Reverts the OpenVR part of fcf5981
JulianGro
added
bug
ada-tv
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2242
Reverts the OpenVR part of fcf5981
I probably spent 40 hours on #2242 already, and I don't feel like I am any closer to the issue than before. I get the impression that it is a bug in our renderer which happens only on OpenVR's reprojection Matrix. If I set OpenXR to exactly the same culling projection, the picture is all warped, but the issue doesn't appear. So, as far as I can tell, the culling projection doesn't actually have anything to do with the issue? Not being able to reproduce the issue on OpenXR, even with hard-coding a known-broken culling projection, seems very fishy to me.
Whatever the case, it seems preferable to have the culling projection wrong for the right eye, rather than having flashing black squares and upside down haze on most configurations.
Some culling projection values do work, so we could theoretically hard-code some known-working values and map whatever OpenVR outputs to the nearest known-good value, but that would be incredibly hacky.
(I tested this PR locally, and it does what I expect.)