Skip to content

update to libnode24 - #2368

Merged
RTUnreal merged 2 commits into
masterfrom
libnode24
Jul 18, 2026
Merged

update to libnode24#2368
RTUnreal merged 2 commits into
masterfrom
libnode24

Conversation

@RTUnreal

@RTUnreal RTUnreal commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

No, spectacular news. But as a sidenote, I needed to patch the upstream libv8 nix package because embedding v8 into a shared library required a new define

Conan recipe change: overte-org/overte-conan-recipes#60

@RTUnreal
RTUnreal requested review from JulianGro and ada-tv July 17, 2026 18:51
@RTUnreal RTUnreal added needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested v8 Bugs related to the new V8 scripting engine labels Jul 17, 2026
@JulianGro

Copy link
Copy Markdown
Member

I added an updated Conan package. I won't be in the office for as long as it would take to test, so I'll leave testing to the CI pipeline for now.

@JulianGro

Copy link
Copy Markdown
Member

Apparently, libnode 24 doesn't support GCC 11 anymore. I wouldn't want to bump up our targeted system almost a year early, especially since libnode 22 is still supported until May 2027, which is in line with the next planned bump to a newer Ubuntu version.

@ada-tv ada-tv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. The CI runs are failing to build the new libnode.

@JulianGro

JulianGro commented Jul 18, 2026

Copy link
Copy Markdown
Member

As far as I can tell, this builds and runs with libnode22 as well. https://github.com/overte-org/overte/actions/runs/29605366291
So maybe we could stay on libnode22 and you only use libnode24 on NixOS? We could then immediately update to libnode24 when we upgrade to a newer Ubuntu version in the future.

For now, I just got rid of my commit adding the libnode24 Conan package, so it doesn't block this PR.

@RTUnreal

Copy link
Copy Markdown
Collaborator Author

Sure, the changes were mostly upgrading from deprecated functions, so I have no qualm using libnode24 ahead of everybody else.

@RTUnreal

Copy link
Copy Markdown
Collaborator Author

@JulianGro should we merge it if it is fine?

@RTUnreal
RTUnreal merged commit ce641ed into master Jul 18, 2026
6 of 7 checks passed
@RTUnreal
RTUnreal deleted the libnode24 branch July 18, 2026 17:16
@JulianGro JulianGro added CR approved This pull request has been successfully code reviewed QA approved This pull request has been successfully tested and removed needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CR approved This pull request has been successfully code reviewed QA approved This pull request has been successfully tested v8 Bugs related to the new V8 scripting engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants