Conversation
|
I added an updated Conan package. I won't be in the office for as long as it would take to test, so I'll leave testing to the CI pipeline for now. |
|
Apparently, libnode 24 doesn't support GCC 11 anymore. I wouldn't want to bump up our targeted system almost a year early, especially since libnode 22 is still supported until May 2027, which is in line with the next planned bump to a newer Ubuntu version. |
ada-tv
left a comment
There was a problem hiding this comment.
Code changes LGTM. The CI runs are failing to build the new libnode.
|
As far as I can tell, this builds and runs with libnode22 as well. https://github.com/overte-org/overte/actions/runs/29605366291 For now, I just got rid of my commit adding the libnode24 Conan package, so it doesn't block this PR. |
|
Sure, the changes were mostly upgrading from deprecated functions, so I have no qualm using libnode24 ahead of everybody else. |
|
@JulianGro should we merge it if it is fine? |
No, spectacular news. But as a sidenote, I needed to patch the upstream libv8 nix package because embedding v8 into a shared library required a new define
Conan recipe change: overte-org/overte-conan-recipes#60