comment out scope guard in ScriptManager::waitTillDoneRunning - #2355
Draft
ada-tv wants to merge 1 commit into
Draft
comment out scope guard in ScriptManager::waitTillDoneRunning#2355ada-tv wants to merge 1 commit into
ScriptManager::waitTillDoneRunning#2355ada-tv wants to merge 1 commit into
Conversation
ada-tv
added
bug
Member
|
The 10 megabytes of new CodeChecker warnings is an issue on my end. I enabled CTU while fixing CodeChecker master uploads, but apparently broke master builds at the same time, so the PR build is showing all the extra warnings that checking with CTU yields. |
Member
|
I just gave this a try, and I don't crash when switching domains and I don't deadlock or crash on shutdown. Looks promising. If we do want to merge this, we should probably get rid of the thing instead of just commenting it out. |
ada-tv
marked this pull request as draft
July 4, 2026 17:16
Collaborator
Author
|
While this stops the crash, I have a feeling the root cause is actually that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.