Skip to content

Fix deselected entities not being removed the editHandleHighlightList #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LimeProgramming wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −1
Open

Fix deselected entities not being removed the editHandleHighlightList #2341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion scripts/system/create/entitySelectionTool/entitySelectionTool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,21 @@ SelectionManager = (function() {
that.setSelections = function(entityIDs, caller) {
print("setSelections: " + JSON.stringify(entityIDs));
Script.logBacktrace("setSelections");

// Clear highlight handle list
const selection = Selection.getSelectedItemsList(HIGHLIGHT_LIST_NAME);

if ( selection && selection.entities && selection.entities.length > 0 ) {
for (let i = 0; i < that.selections.length; i++) {
Selection.removeFromSelectedItemsList(HIGHLIGHT_LIST_NAME, "entity", that.selections[i]);
}
}

// Clear class-level selections list
that.selections = [];
for (var i = 0; i < entityIDs.length; i++) {

// Add entities to the highlight handle list and Class selections list
for (let i = 0; i < entityIDs.length; i++) {
var entityID = entityIDs[i];
that.selections.push(entityID);
Selection.addToSelectedItemsList(HIGHLIGHT_LIST_NAME, "entity", entityID);
Expand Down Expand Up @@ -290,6 +303,17 @@ SelectionManager = (function() {
};

that.clearSelections = function(caller) {

const selection = Selection.getSelectedItemsList(HIGHLIGHT_LIST_NAME);

// Clear highlight handle list
if ( selection && selection.entities && selection.entities.length > 0 ) {
for (let i = 0; i < that.selections.length; i++) {
Selection.removeFromSelectedItemsList(HIGHLIGHT_LIST_NAME, "entity", that.selections[i]);
}
}

// Clear class-level selections list
that.selections = [];
that._update(true, caller);
};
Expand Down
Loading