Initial attempt at floating point debugging - #2340
Open
vatral wants to merge 2 commits into
Open
Conversation
RTUnreal
reviewed
Jun 21, 2026
ada-tv
requested changes
Jun 21, 2026
ada-tv
left a comment
Collaborator
There was a problem hiding this comment.
The Windows build is failing. I don't think fedisableexcept has an equivalent on Windows, so the OffscreenSurface changes might need to be ifdef'd.
libraries\qml\src\qml\OffscreenSurface.cpp(468,5): error C3861: 'fedisableexcept': identifier not found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a hack to try to get to the bottom of all the NaN issues.
It adds a new parameter, which allows to enable floating point exceptions. There's a hack to disable this around QML because when enabled, there's an apparently limitless amount of divides by zero coming from the QML for
AvatarInputsBar.qmlfor some reason.With this patch, and running
interface --floatExcept divbyzerohere's what I get:@ada-tv -- Does this help any?