Skip to content

Correct spotlight attenuation angle calculation #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ada-tv wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

Correct spotlight attenuation angle calculation #2250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libraries/render-utils/src/LightLocal.slh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,14 @@ vec4 evalLocalLighting(ivec3 cluster, int numLights, vec3 fragWorldPos, SurfaceD

updateSurfaceDataWithLight(surface, fragLightDir);

float spotAngle = lightVolume_getSpotAngleCos(light.volume);
float spotExponent = lightIrradiance_getFalloffSpot(light.irradiance);
// TODO: expose configurable inner radius, this fixed scale just takes the sharp edges away
// FIXME: the exponent thing is a bit weird and tricky to replicate, it applied an exponent
// over a 180° spotlight that was clipped against the outer radius
float spotEpsilon = spotAngle - pow(spotAngle * 0.98, spotExponent);
cosSpotAngle = clamp((cosSpotAngle - spotAngle) / max(spotEpsilon, 0.0001), 0.0, 1.0);

// Eval attenuation
float radialAttenuation = lightIrradiance_evalLightAttenuation(light.irradiance, fragLightDistance);
float angularAttenuation = lightIrradiance_evalLightSpotAttenuation(light.irradiance, cosSpotAngle);
Expand Down
Loading