[Bug]: Filter nodes by transport protocol

[bastelfreak]

Is this a critical security issue?

• This is not a security issue.

Describe the Bug

(I don't know how to implement this nor if there even is a sane way to do this)

I've a mixed environment, some nodes run a choria-server, some don't. If I want to run a task and select the choria transport protocol, I can select nodes that don't have choria-server running. Those nodes will fail with:

{
  "items": [
    {
      "value": {
        "_error": {
          "msg": "No agent information available for patroni1.spirit-int.betadots.training (node did not respond to discovery)",
          "kind": "bolt/choria-agent-not-available",
          "details": {}
        }
      },
      "action": "task",
      "object": null,
      "status": "failure",
      "target": "patroni1"
    }
}

I don't know if we could/want to discover supported nodes on demand. Or add something like "choria-server is running here" as an attribute to nodes in the Foreman inventory?

Expected Behavior

Don't allow me to start tasks via choria transport on nodes that don't support it.

Steps to Reproduce

run a task on a node withour choria-server

Environment

foreman 3.18.1

Additional Context

No response

Relevant log output

[binford2k]

the "easy" way out is to add a fact for choria and then make a host group to run against.

The more sane way would be to generalize it. Maybe a structured fact with an available_transports key; chunked so that plugins that add transports could also add their information to it.