docs: Windows builds require the C++ ATL component - #39398
Conversation
rescle.cpp includes atlstr.h and links atls.lib; with only the bare C++ workload the build fails at object 1207/1240 (fatal error: 'atlstr.h' file not found) and again at link (cannot open atls.lib). Verified on current main: installing Microsoft.VisualStudio.Component.VC.ATL fixes both.
There was a problem hiding this comment.
Pull request overview
Updates the Windows build documentation to include an additional Visual Studio component required to compile/link Bun’s Windows-specific JSC resource code, preventing fresh Windows setups from failing due to missing ATL headers/libraries.
Changes:
- Document that the Visual Studio install must include the “C++ ATL for latest build tools” component (needed for
atlstr.h/atls.lib). - Update the WinGet install command to include
Microsoft.VisualStudio.Component.VC.ATL.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 6 remain after this review. WalkthroughThe Windows build documentation now requires Visual Studio’s ATL component. The WinGet command installs ChangesWindows build prerequisites
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This localized documentation update clarifies the Windows build prerequisite and includes the ATL component in the setup command; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Documents a missing Windows build prerequisite: the "C++ ATL for latest build tools" VS component.
src/jsc/bindings/windows/rescle.cppincludesatlstr.h(line 35) and linksatls.lib; neither ships with the bare "Desktop Development with C++" workload. Also addsMicrosoft.VisualStudio.Component.VC.ATLto the WinGet install line so a fresh setup gets it from the start.How did you verify your code works?
Fresh Windows build of current
main(c3995e43d5) following the existing doc verbatim fails twice: at object 1207/1240 (fatal error: 'atlstr.h' file not found) and, with headers borrowed from another toolset, again at link (lld-link: error: could not open 'atls.lib'). InstallingMicrosoft.VisualStudio.Component.VC.ATLvia the VS installer fixed both and the build completed (bun-debug.exe, used to verify #39383).