Skip to content

docs: Windows builds require the C++ ATL component - #39398

Open
JF10R wants to merge 1 commit into
oven-sh:mainfrom
JF10R:docs-windows-atl
Open

docs: Windows builds require the C++ ATL component#39398
JF10R wants to merge 1 commit into
oven-sh:mainfrom
JF10R:docs-windows-atl

Conversation

@JF10R

@JF10R JF10R commented Aug 17, 2026

Copy link
Copy Markdown

What does this PR do?

Documents a missing Windows build prerequisite: the "C++ ATL for latest build tools" VS component. src/jsc/bindings/windows/rescle.cpp includes atlstr.h (line 35) and links atls.lib; neither ships with the bare "Desktop Development with C++" workload. Also adds Microsoft.VisualStudio.Component.VC.ATL to the WinGet install line so a fresh setup gets it from the start.

How did you verify your code works?

Fresh Windows build of current main (c3995e43d5) following the existing doc verbatim fails twice: at object 1207/1240 (fatal error: 'atlstr.h' file not found) and, with headers borrowed from another toolset, again at link (lld-link: error: could not open 'atls.lib'). Installing Microsoft.VisualStudio.Component.VC.ATL via the VS installer fixed both and the build completed (bun-debug.exe, used to verify #39383).

rescle.cpp includes atlstr.h and links atls.lib; with only the bare
C++ workload the build fails at object 1207/1240 (fatal error:
'atlstr.h' file not found) and again at link (cannot open atls.lib).
Verified on current main: installing
Microsoft.VisualStudio.Component.VC.ATL fixes both.
Copilot AI lite review requested due to automatic review settings August 17, 2026 02:52

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Windows build documentation to include an additional Visual Studio component required to compile/link Bun’s Windows-specific JSC resource code, preventing fresh Windows setups from failing due to missing ATL headers/libraries.

Changes:

  • Document that the Visual Studio install must include the “C++ ATL for latest build tools” component (needed for atlstr.h / atls.lib).
  • Update the WinGet install command to include Microsoft.VisualStudio.Component.VC.ATL.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ade63a3d-bb0c-40e2-99b4-74579b50728e

📥 Commits

Reviewing files that changed from the base of the PR and between fea1829 and d4e3c1d.

📒 Files selected for processing (1)
  • docs/project/building-windows.mdx

Included review availability: Your plan includes up to 10 reviews per rolling hour; 6 remain after this review.


Walkthrough

The Windows build documentation now requires Visual Studio’s ATL component. The WinGet command installs Microsoft.VisualStudio.Component.VC.ATL with the existing components.

Changes

Windows build prerequisites

Layer / File(s) Summary
Document the ATL prerequisite
docs/project/building-windows.mdx
The prerequisites mention the ATL component required by rescle.cpp. The WinGet command installs Microsoft.VisualStudio.Component.VC.ATL.

Suggested reviewers: robobun

Merge Risk: ⚪ Minimal · up to d4e3c

This localized documentation update clarifies the Windows build prerequisite and includes the ATL component in the setup command; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description includes both required sections and clearly explains the documentation change and the Windows build verification.
Title check ✅ Passed The title clearly and concisely identifies the main documentation change: the required C++ ATL component for Windows builds.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants