feat(hitl): add subscribe() to HitlResolverRegistry - #53
Merged
Merged
Conversation
- HitlResolverRegistry.subscribe()/unsubscribe() (and the ...user_update counterparts) let one or more callbacks be notified the instant a HITL request is registered -- synchronously, inside register() itself. - Replaces polling get_pending_for_session() in a retry loop: that pattern had a real gap between "a tool call started" (an early, structural signal a caller might see before the request itself exists) and "the request actually exists" (written by the tool's own execution), so a consumer had to poll and hope. Subscribers now see the request the moment it's written, no gap to poll around. - Additive and never-reset -- the same pattern as ObservabilityOperator. subscribe() and KernelDriver.subscribe_exchange() -- so more than one consumer (e.g. a Webex bot and a CLI console) can each subscribe once and coexist, instead of one overwriting another. Signed-off-by: Jordan Augé <augjorda@cisco.com>
jordanauge
force-pushed
the
feat/hitl-registry-subscribe
branch
from
September 4, 2026 14:53
258abb7 to
6534375
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
counterparts) let one or more callbacks be notified the instant a HITL
request is registered -- synchronously, inside register() itself.
had a real gap between "a tool call started" (an early, structural
signal a caller might see before the request itself exists) and "the
request actually exists" (written by the tool's own execution), so a
consumer had to poll and hope. Subscribers now see the request the
moment it's written, no gap to poll around.
subscribe() and KernelDriver.subscribe_exchange() -- so more than one
consumer (e.g. a Webex bot and a CLI console) can each subscribe once
and coexist, instead of one overwriting another.