feat: experiment overlays (-x flag) and benchmark correctness fixes - #42
Merged
Conversation
Adds -x / --experiment-overlay to benchmark run; fixes 3 benchmark bugs
found during development.
New ExperimentOverlay manifest kind: a YAML file that deep-merges into
experiment.yaml before validation, keeping operational concerns out of
the experiment spec.
mas-lab benchmark run experiment.yaml \
-x overlays/local-dev.yaml \ # cache + n_runs override
-x pipelines/standard-eval.yaml # add reusable eval pipeline
Semantics:
- Precedence: experiment.yaml < overlay(-x) < --infra < --set
- RFC 7386 JSON Merge Patch: dicts merge recursively, everything else
(scalars, lists) replaces. To extend a pipeline list, provide the
full desired list in the overlay.
- Paths resolved relative to experiment.yaml directory
Files: execution/experiment_overlay.py, engine.py, run_batch/{__init__,
load}.py, worker.py, cli/commands/benchmark/run.py
- cache: runs with status=error in result.json are no longer treated as
cache hits; absent or unreadable result.json is also a miss (a run
that crashed before writing its result must not be reused)
- plotnine: force matplotlib.use('Agg') before import so the step works
from benchmark worker threads, not only from the main thread
- bootstrap.py: remove stale import of mas.runtime.boundary.context.skills
deleted in cb8709d; the dead import crashed every agent run
Signed-off-by: Jordan Augé <augjorda@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds -x / --experiment-overlay to benchmark run; fixes 3 benchmark bugs
found during development.
New ExperimentOverlay manifest kind: a YAML file that deep-merges into
experiment.yaml before validation, keeping operational concerns out of
the experiment spec.
mas-lab benchmark run experiment.yaml
-x overlays/local-dev.yaml \ # cache + n_runs override
-x pipelines/standard-eval.yaml # add reusable eval pipeline
Semantics:
(scalars, lists) replaces. To extend a pipeline list, provide the
full desired list in the overlay.
Files: execution/experiment_overlay.py, engine.py, run_batch/{init,
load}.py, worker.py, cli/commands/benchmark/run.py
cache hits; absent or unreadable result.json is also a miss (a run
that crashed before writing its result must not be reused)
from benchmark worker threads, not only from the main thread
deleted in cb8709d; the dead import crashed every agent run
Signed-off-by: Jordan Augé augjorda@cisco.com