This repository was archived by the owner on Jan 20, 2022. It is now read-only.
fix: allow / to be used anywhere, not just a new line - #414
Open
iamsaumya wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Hey Tom, Please review this PR whenever you get some time. I don't have much confidence in the PR because I don't understand the codebase yet. |
Member
|
This allows the menu to be triggered but the issue is more nuanced as previously it expects the current paragraph to be empty, using the same logic on a paragraph or other node that contains content will wipe it away or attempt to insert things in invalid locations. There just needs to be some care about ensuring that the block insertion works as expected without losing any content whereever it's called from. The hovering menu itself also needs to be visually positioned next to the "/". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #218