Skip to content

fix(ui): lint-clean LogsScreen — composition-safe resources and remembered state #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oustery merged 1 commit into from
Nov 12, 2026
Merged

fix(ui): lint-clean LogsScreen — composition-safe resources and remembered state #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions app/src/main/java/io/github/oustery/opencodephone/ui/logs/LogsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ fun LogsScreen(graph: io.github.oustery.opencodephone.AppGraph) {
entry.error?.contains(query, ignoreCase = true) == true)
}
}
val atBottom by derivedStateOf {
val atBottom by remember { derivedStateOf {
val last = listState.layoutInfo.visibleItemsInfo.lastOrNull()
last == null || last.index >= listState.layoutInfo.totalItemsCount - 2
}
} }
LaunchedEffect(filtered.size, autoScroll) {
if (autoScroll && filtered.isNotEmpty() && atBottom) {
listState.scrollToItem(filtered.size - 1)
Expand All @@ -82,6 +82,11 @@ fun LogsScreen(graph: io.github.oustery.opencodephone.AppGraph) {

val export = remember(filtered) { AppLog.exportText() }
val context = androidx.compose.ui.platform.LocalContext.current
// Resolve in composition: stringResource() is configuration-aware, while
// context.getString() in a composable trips lint's
// LocalContextGetResourceValueCall and can go stale on config changes.
val shareSubject = stringResource(R.string.logs_share_subject)
val shareLabel = stringResource(R.string.logs_share)

ScreenHeader(
title = stringResource(R.string.logs_title),
Expand All @@ -98,13 +103,10 @@ fun LogsScreen(graph: io.github.oustery.opencodephone.AppGraph) {
val intent = android.content.Intent(android.content.Intent.ACTION_SEND).apply {
type = "text/plain"
putExtra(android.content.Intent.EXTRA_TEXT, export.take(90_000))
putExtra(
android.content.Intent.EXTRA_SUBJECT,
context.getString(R.string.logs_share_subject),
)
putExtra(android.content.Intent.EXTRA_SUBJECT, shareSubject)
}
context.startActivity(
android.content.Intent.createChooser(intent, context.getString(R.string.logs_share)),
android.content.Intent.createChooser(intent, shareLabel),
)
}) {
Icon(
Expand Down
Loading