chore: install Docker CE in the repo devcontainer so it opens again - #11
Merged
Conversation
The repo's own devcontainer fails to open locally. `base:ubuntu` floats and
has rolled forward to Ubuntu 26.04 "resolute", for which no moby-cli
packages exist, so the docker-in-docker feature aborts during the image
build:
(!) The 'moby' option is not supported on ubuntu 'resolute' because
'moby-cli' and related system packages are not available in that
distribution.
Setting moby:false installs Docker CE instead, which does have packages for
resolute. Verified by reproducing the failure with `devcontainer up`, then
confirming a clean `devcontainer build` and `devcontainer up` afterwards
with a working docker, node and postCreateCommand inside the container.
Preferred over pinning the base image: the base tags float by design here,
and pinning the contributor environment would freeze it on an older LTS
than the images the repo actually publishes.
Feature digests are unchanged, so devcontainer-lock.json still applies.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the repository’s own devcontainer configuration to remain buildable/openable after the floating mcr.microsoft.com/devcontainers/base:ubuntu image advanced to Ubuntu 26.04 (“resolute”), where moby-cli packages aren’t available and the docker-in-docker feature fails with its default settings.
Changes:
- Configure
docker-in-docker:2with"moby": falseto install Docker CE instead of Moby on the floating Ubuntu base image. - Add an inline rationale comment explaining the Ubuntu 26.04/moby package availability issue and when to revisit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo's own devcontainer fails to open locally.
base:ubuntufloats and has rolled forward to Ubuntu 26.04 "resolute", for which no moby-cli packages exist, so the docker-in-docker feature aborts during the image build:(!) The 'moby' option is not supported on ubuntu 'resolute' because
'moby-cli' and related system packages are not available in that
distribution.
Setting moby:false installs Docker CE instead, which does have packages for resolute. Verified by reproducing the failure with
devcontainer up, then confirming a cleandevcontainer buildanddevcontainer upafterwards with a working docker, node and postCreateCommand inside the container.Preferred over pinning the base image: the base tags float by design here, and pinning the contributor environment would freeze it on an older LTS than the images the repo actually publishes.
Feature digests are unchanged, so devcontainer-lock.json still applies.