Skip to content

Fixes for Django 3 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darkman66 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes for Django 3 #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Quick start
-----------

Requirements :
* Django 1.7.4 or above.
* Django 1.7.4 or above. (also 3.x)
* Python 2.7 or 3.4

@henri-hulski henri-hulski Feb 9, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 2.7 or 3.4+ should be fine and Django 4 either.

* django.contrib.staticfiles app to serve static files

Expand Down
3 changes: 2 additions & 1 deletion progressbarupload/templatetags/progress_bar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
from django.forms.widgets import Media
from django.utils.safestring import mark_safe

if DJANGO_VERSION[0] == 2:

if DJANGO_VERSION[0] in (2, 3):

@henri-hulski henri-hulski Feb 9, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To support also Django 4+ just use:

if DJANGO_VERSION[0] == 1:
    from django.core.urlresolvers import reverse
else:
    from django.urls import reverse

from django.urls import reverse
elif DJANGO_VERSION[0] == 1:
from django.core.urlresolvers import reverse
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

setup(
name='django-progressbarupload',
version='0.1.8',
version='0.1.9',
packages=find_packages(),
include_package_data=True,
license='BSD License',
Expand Down