feat: keep the process alive on errors that escape a jsk eval - #22
Merged
Conversation
jsk js/cjs/mjs/sh already catch and report errors within a command's own awaited chain, but an eval can also fail outside it (an unawaited promise that rejects later, an event listener it registered that throws) — Node's default for uncaughtException/unhandledRejection is to kill the process. Add catchProcessErrors (on by default) so djsk installs its own handlers that log instead of crashing, with an opt-out for bots that already handle these themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsk js/cjs/mjs/sh already catch and report errors within a command's own awaited chain, but an eval can also fail outside it (an unawaited promise that rejects later, an event listener it registered that throws) — Node's default for uncaughtException/unhandledRejection is to kill the process. Add catchProcessErrors (on by default) so djsk installs its own handlers that log instead of crashing, with an opt-out for bots that already handle these themselves.
Summary
Why?
Related issue(s)
closes
Check
pnpm check(lint, format & typecheck)pnpm test(functions test)pnpm build(dist/)