Source OAuth credentials from xcconfig at compile time - #55
Merged
Conversation
Moves OMGLOL_CLIENT_ID, OMGLOL_CLIENT_SECRET, and OMGLOL_REDIRECT_URI out of the hardcoded AuthRequestFactory and out of Info.plist. A new GenerateOAuthSecrets build phase reads the three xcconfig values (available as env vars during the build) and writes a Swift source file to DERIVED_FILE_DIR; that file is compiled directly into the binary so the secrets never appear in any bundle resource. On the Swift side, AuthRequestFactory is refactored from a static-method enum to an injectable struct that holds an OAuthClientConfiguration value, and the configuration is threaded through the Auth package's factory and environment chain. Scripts/setup-environment.zsh is now superseded — credentials go in Config/Triton.local.xcconfig instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
OMGLOL_CLIENT_ID,OMGLOL_CLIENT_SECRET, andOMGLOL_REDIRECT_URIout of the hardcodedAuthRequestFactoryand out ofInfo.plist. A newGenerateOAuthSecretsbuild phase reads the threexcconfigvalues (available as env vars during the build) and writes a Swift source file toDERIVED_FILE_DIR; that file is compiled directly into the binary so the secrets never appear in any bundle resource.On the Swift side,
AuthRequestFactoryis refactored from a static-method enum to an injectable struct that holds anOAuthClientConfigurationvalue, and the configuration is threaded through the Auth package's factory and environment chain.Scripts/setup-environment.zshis now superseded — credentials go inConfig/Triton.local.xcconfiginstead.