Merged
Conversation
…r redirect URIs, logout settings, and URLs
Contributor
There was a problem hiding this comment.
Pull request overview
Enhances the KeycloakClient custom resource and its Pulumi-based provisioner to support additional Keycloak client configuration fields (URLs, redirect URIs, PKCE, web origins, and front-channel logout), and updates the generated artifacts/CRDs accordingly. The PR also includes unrelated HelmReleaseV2 CRD schema changes that appear outside the scope implied by the PR title.
Changes:
- Extend
KeycloakClientSpecwith Root/Base URL, redirect URIs (login/logout), PKCE method, web origins, and front-channel logout fields. - Wire the new spec fields into the Pulumi Keycloak OpenID client provisioning arguments.
- Regenerate/apply CRD schema changes for KeycloakClient (and also update HelmReleaseV2 CRD schema).
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/generated/applyconfiguration/provisioning/v1alpha1/keycloakclientspec.go | Adds apply-configuration fields and With* builders for the new KeycloakClientSpec properties. |
| pkg/apis/provisioning/v1alpha1/zz_generated.deepcopy.go | Updates deepcopy logic to properly copy newly added slice fields in KeycloakClientSpec. |
| pkg/apis/provisioning/v1alpha1/keycloakClientTypes.go | Extends the KeycloakClientSpec API type with new Keycloak-related configuration fields. |
| internal/controllers/provisioning/provisioners/pulumi/keycloak_client.go | Passes new Keycloak client settings from the CR spec into Pulumi OpenID client creation. |
| helm/crds/provisioning.totalsoft.ro_keycloakclients.yaml | Exposes the new KeycloakClientSpec fields in the published CRD schema. |
| helm/crds/provisioning.totalsoft.ro_helmreleasev2s.yaml | Updates HelmReleaseV2 CRD schema (appears unrelated to the PR title/scope). |
Files not reviewed (1)
- pkg/apis/provisioning/v1alpha1/zz_generated.deepcopy.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+83
to
+85
| // FrontchannelLogoutUrl The URL Keycloak calls to perform front-channel logout. It is only applicable when FrontchannelLogoutEnabled is true. | ||
| // +optional | ||
| FrontchannelLogoutUrl string `json:"frontchannelLogoutUrl,omitempty"` |
Comment on lines
+167
to
+170
| frontchannelLogoutUrl: | ||
| description: FrontchannelLogoutUrl The URL Keycloak calls to perform | ||
| front-channel logout. It is only applicable when FrontchannelLogoutEnabled | ||
| is true. |
Comment on lines
+440
to
+446
| required: | ||
| - apiVersion | ||
| - current | ||
| - kind |
fraliv13
previously approved these changes
Jul 23, 2026
fraliv13
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.