Skip to content

feat: update OSPS-QA-06 - #547

Merged
eddie-knight merged 3 commits into
ossf:mainfrom
Satarupa22-SD:OSPS-QA-06
Oct 7, 2026
Merged

eddie-knight merged 3 commits into
ossf:mainfrom
Satarupa22-SD:OSPS-QA-06

Conversation

@Satarupa22-SD

Copy link
Copy Markdown
Contributor

Refer #546

Signed-off-by: Satarupa22-SD <satarupa2212@gmail.com>
Signed-off-by: Satarupa22-SD <satarupa2212@gmail.com>
eddie-knight
eddie-knight previously approved these changes Aug 28, 2026
@eddie-knight
eddie-knight enabled auto-merge (squash) September 8, 2026 15:13

@evankanderson evankanderson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like a little more justification for splitting this; I feel like documenting the various environments and methods for running the tests as a single control is not unreasonable; this could be phrased without "and" as:

The project documentation MUST clearly document all supported test environments, including invocation instructions.

@funnelfiasco

Copy link
Copy Markdown
Contributor

I agree with Evan's suggestion. What we really want is for projects to document tests. "How" and "when" are elements of that documentation and don't require separate controls. This is another case of "state the outcome in the text and provide more details in the description"

@Satarupa22-SD

Copy link
Copy Markdown
Contributor Author

The project documentation MUST clearly document all supported test environments, including how tests are invoked, manually or by automated triggers.

Instead of splitting it into two separate requirements can we use the above. CC: @funnelfiasco @evankanderson @eddie-knight

@evankanderson

Copy link
Copy Markdown
Contributor

The project documentation MUST clearly document all supported test environments, including how tests are invoked, manually or by automated triggers.

Instead of splitting it into two separate requirements can we use the above. CC: @funnelfiasco @evankanderson @eddie-knight

, manually or by automated triggers feels like a bit of a comma-splice. Maybe , _whether_ manually or by automated triggers?

auto-merge was automatically disabled September 29, 2026 21:01

Head branch was pushed to by a user without write access

@Satarupa22-SD

Copy link
Copy Markdown
Contributor Author

@evankanderson I have updated this as per the changes you proposed.

Signed-off-by: Satarupa22-SD <satarupa2212@gmail.com>
@eddie-knight
eddie-knight merged commit 96a7918 into ossf:main Oct 7, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants