Skip to content

Enhance security guidelines for software supply chain - #387

Closed
JustinCappos wants to merge 2 commits into
ossf:mainfrom
JustinCappos:main
Closed

JustinCappos wants to merge 2 commits into
ossf:mainfrom
JustinCappos:main

Conversation

@JustinCappos

Copy link
Copy Markdown

This PR which needs community feedback and also needs a more precise linking to the specific standards which apply.

Signed-off-by: Justin Cappos <justincappos@gmail.com>

@funnelfiasco funnelfiasco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the general direction. I think we need more clarity (and also feedback from others, of course)

Comment thread baseline/OSPS-SA.yaml
- id: OSPS-SA-04.01
text: |
A project MUST perform a security assessment of the software
supply chain security practices of the project. This should

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
supply chain security practices of the project. This should
supply chain security practices of the project to

If we don't introduce new instances of "should" in the title or text fields, I won't have to go back and remove them when I get around to doing that. :-)

Comment thread baseline/OSPS-SA.yaml

- id: OSPS-SA-04
title: |
The project MUST assess the security risks inherent in their software supply chain practices.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need some wordsmithing to be a little more clear, but I wouldn't block on this if we can't think of anything.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there projects that are doing this well, doing this poorly today? What does good enough look like?

Comment thread baseline/OSPS-SA.yaml
- Maturity Level 2
- Maturity Level 3
recommendation: |
Performing a security assessment informs both project members as well

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a place where we'll really want some reference implementations to direct people to.

Comment thread baseline/OSPS-SA.yaml
practices. Ensure this is updated as practices change.

- id: OSPS-SA-04.02
text: |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on what distinction you're drawing between 04.01 and 04.02. It seems like some of 04.02 is duplicative, and if so, we can drop that. Is the idea that 04.02 says "do what you did for 04.01, but also include your dependencies in it"?

The text should also be shorter here, ideally 1-2 sentences, and we can expand in the recommendation if needed.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also mean to look at your tooling. Are you using appropriate VCS controls? Are you generating attestations? Is your software update infrastructure compromise-resilient? Do you have a recovery plan for a compromise in these areas?

Comment thread baseline/OSPS-SA.yaml

- id: OSPS-SA-04
title: |
The project MUST assess the security risks inherent in their software supply chain practices.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there projects that are doing this well, doing this poorly today? What does good enough look like?

Comment thread baseline/OSPS-SA.yaml
title: |
The project MUST assess the security risks inherent in their software supply chain practices.
objective: |
Provide project maintainers an understanding of the risks in their software

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "tooling" specific or should that be removed?

Comment thread baseline/OSPS-SA.yaml
Comment on lines +357 to +358
that could occur in the supply chain of the software, including
both the tool.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "including both the tool."?

Comment thread baseline/OSPS-SA.yaml
text: |
When the project has made a release, the project MUST perform a
security assessment of their software supply chain practices and
have analyzed their dependencies. This should also include means

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency management should be effective covered by existing controls.

Comment thread baseline/OSPS-SA.yaml
applicability:
- Maturity Level 3
recommendation: |
Threat modeling of the software supply chain is an essential part

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there existing examples of open source projects doing this well?

@david-a-wheeler

Copy link
Copy Markdown
Contributor

The goals are sensible, but this needs more specifics. What exactly are we expecting people to do? How will they know when they're done? What are the specific examples of the risks you intend to tackle? E.g.: typosquatting, dependency confusion, malicious GitHub Actions, malicious packages, etc.

We discussed this today, and the plan is to open a new issue to discuss this in more detail and work out more specific to address this.

@david-a-wheeler

Copy link
Copy Markdown
Contributor

@eddie-knight

@evankanderson

Copy link
Copy Markdown
Contributor

Related existing controls:

  • DO-06 Publish Dependency Management Policy
  • BR-05 Use Standardized Dependency Management Tools
  • QA-02 Publish Software Dependencies
  • BR-01 Prevent Untrusted Input When Building & Releasing
  • AC-04 Enforce Least Privilege on CI/CD Pipelines
  • VM-05 Publish and Enforce a Dependency Remediation Policy
  • QA-05 Prevent Executables in the Codebase
  • QA-06 Use Automated Testing in CI/CD Pipelines

@eddie-knight

eddie-knight commented Mar 17, 2026 •

Copy link
Copy Markdown
Contributor

Closing this PR to force our attention on the high-level objective. Let's continue the discussion in the new issue (linked above this comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants