🐛 Fall back when check suites are truncated - #5150
Open
ECD5A wants to merge 1 commit into
Open
Conversation
ECD5A
requested review from
jeffmendoza and
justaugustus
and removed request for
a team
July 30, 2026 23:21
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
Signed-off-by: ECD5A <111098024+ECD5A@users.noreply.github.com>
ECD5A
force-pushed
the
fix/checksuite-truncation-fallback
branch
from
August 10, 2026 00:48
cb5390a to
7b4a590
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
GitHub GraphQL check-suite results are cached even when the
checkSuitesconnection is truncated.When a commit has more check suites than the GraphQL query returns, the partial result is treated as complete. Because the commit SHA is present in the cache,
listCheckRunsForRefdoes not use its existing REST fallback.As a result, successful CI check runs located after the first GraphQL page can be missed by the CI-Tests and SAST checks.
What is the new behavior (if this is a feature change)?
The GitHub client now reads
PageInfo.HasNextPagefrom thecheckSuitesconnection.When the GraphQL result is truncated, the pull request head SHA is not added to the check-run cache. This produces a cache miss and allows the existing REST fallback to retrieve the check runs for that ref.
A regression test verifies that truncated GraphQL data triggers the REST fallback and returns a successful
github-actionscheck run.Which issue(s) this PR fixes
Fixes #5149
Special notes for your reviewer
The branch contains one DCO-signed commit.
Fork validation results:
build: passeddocker-build: passedgolangci-lint: passedgitlab-tests: passed:bug:prefixThe fork's Dependency Review workflow could not run because Dependency Graph is not enabled on the fork.
The integration workflow reported two unrelated failures in
e2e/vulnerabilities_test.go. The live OSV response returned three vulnerability warnings and score 7, while the test fixture expected four warnings and score 6. The other 58 executed integration specifications passed. This change does not modify vulnerability-related code.Does this PR introduce a user-facing change?