v1.29.0 dry-run: flip switch-on feature flags to default - #870
v1.29.0 dry-run: flip switch-on feature flags to default#870mzihlmann wants to merge 13 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
8dc802f to
0642f48
Compare
9c96a9f to
c6949f8
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6b67e8c to
fc25164
Compare
… RUN_VIA_TINI, blocked on RISC-V tini)
fc25164 to
8138cb0
Compare
Do not merge. Dry-run to surface v1.29.0 regressions in CI ahead of the release, since last time issues only showed up just before cutting the release.
Graduates the feature flags due in v1.29.0 per the lifecycle in docs/releases.md. Activated flags default to
truenow and are slated for removal in v1.30.0. The v1.28.0-activated flags are removed and their behavior is now unconditional. No golden plan data changes on this branch, the cases that assert legacy plans pin the graduated flags off instead.FF_KANIKO_RUN_VIA_TINI stays default off, held back until the tini binary ships for RISC-V. It is the only switch-on flag not flipped here. The --image-format=oci default flip lives in #850 and is not on main yet, so it is out of scope for this branch.
FF_KANIKO_NO_PROPAGATE_ANNOTATIONS is fully retired. Base image annotations are already stripped unconditionally by WithoutAnnotations before a stage is built, so the mz507 base-annotation workaround in newStageBuilder is now redundant and dropped. baseImageDigest is unchanged, since Manifest.Annotations is omitempty and the stripped image already carries none.
FF_KANIKO_OCI_WARMER removal deletes the legacy tarball Warmer path, its unit tests, and the .json manifest sidecar cleanup. The warmer now always writes an ocilayout. FF_KANIKO_IGNORE_CACHED_MANIFEST was only a workaround for the tarball writer rewriting the manifest mediatype, which the ocilayout format fixes at the root, so it goes too.
FF_KANIKO_CROSS_REPO_MOUNT and FF_KANIKO_PATH_SCOPED_REGISTRY_AUTH landed after this branch was first opened and are activated here too, both were documented as becoming default in v1.29.0. Cross-repo mount changes what a push sends, path-scoped auth changes which credential a repository is offered, so both are worth a CI pass before the release.
FF_KANIKO_RELATIVE_LINK_TARGETS is the one flag whose documented v1.29.0 removal is not carried out here. It shipped default
truein v1.28.2, so removing it now would give users weeks rather than a full minor cycle to react.