fix(server): apply SetPolicies policy assignments - #3538
Open
Ivan-Pokhabov wants to merge 1 commit into
Open
Conversation
fujita
reviewed
Aug 31, 2026
| r.setPeerPolicy(id, c) | ||
| if err := r.setPeerPolicy(id, c); err != nil { | ||
| return err | ||
| } |
Member
There was a problem hiding this comment.
reload() has already cleared assignmentMap at this point, so this loop is what restores it. Returning here leaves every id the loop has not reached yet with no assignment, including the global RIB. ap is a map, so which ids survive changes on every call.
|
|
||
| func (r *RoutingPolicy) setPeerPolicy(id string, c oc.ApplyPolicy) { | ||
| func (r *RoutingPolicy) setPeerPolicy(id string, c oc.ApplyPolicy) error { | ||
| for _, dir := range []PolicyDirection{POLICY_DIRECTION_IMPORT, POLICY_DIRECTION_EXPORT} { |
Member
There was a problem hiding this comment.
If this returns an error, I think that it's better to update IMPORT and EXPORT atomically.
Firstly, calling r.getAssignmentFromConfig for both directions, only if both succeeds, then execute setDefaultPolicy and setPolicy for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, SetPolicy ignore new Assignements