Skip to content

fixed cashAddr addresses being decoded incorrectly #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zura2 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixed cashAddr addresses being decoded incorrectly #19

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95a68b3
fixed incorrectly decoding cashaddr format addresses
Jun 16, 2021
4cc017c
fixed convertBits appending extra zero causing incorrect result
Jun 16, 2021
a82f22a
fixed typo
Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cashaddress/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,11 @@ def _cash_string(address_string):
decoded = b32decode(base32string)
if not verify_checksum(prefix, decoded):
raise InvalidAddress('Bad cash address checksum')
converted = convertbits(decoded, 5, 8)
converted = convertbits(decoded[:-8], 5, 8, False)
version = Address._address_type('cash', converted[0])[0]
if prefix == Address.TESTNET_PREFIX:
version += '-TESTNET'
payload = converted[1:-6]
payload = converted[1:]
return Address(version, payload, prefix)


Expand Down