chg: collect results in structures - #15
Merged
Merged
Conversation
We might want to re-use them.
A main reason is that it's useful to be able to recover the tropicalizations. In this commit, we also rename k to a in a few more places (and permute with b).
oskarhenriksson
changed the title
Also some minor fixes the code concerning cotransversality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For many of our functions, there is a lot of expensive auxiliary data (such as tropical linear spaces and stable intersections) that I think would be nice to output along with the bounds. For instance, this auxiliary data is useful for computing tropical homotopies. The auxiliary data also constitutes a certificate that the bounds are correct and is required to reproduce them.
Before, we collected some of this data in tuples, but it was getting a bit confusing and cumbersome to keep track of the ordering. Similarly, it was getting a bit tiresome to write out C, M, L all the time.
This PR introduces a bunch of new Julia structures for augmented vertical systems and the results of our computations.
It is built on top of #14.