ansible: drop obsolete osism-fqcn noqa on blocks#2899
Merged
Conversation
The custom osism-fqcn ansible-lint rule used to emit spurious violations on block/rescue/always constructs, so two manager playbooks carried `# noqa: osism-fqcn` annotations as a workaround. container-images#902 fixes the rule to correctly skip these constructs, and the updated ansible-lint image has been published, so the annotations are no longer needed. Both suppressions sat on genuine block false-positives and removing them keeps CI green: - ansible/manager-part-0.yml: "Debian/Ubuntu specific tasks" block - ansible/manager-part-3.yml: "Try to apply the manager role" block Related-Bug: #1368 AI-assisted: Claude Code Signed-off-by: Roger Luethi <luethi@osism.tech>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two now-unnecessary
# noqa: osism-fqcnannotations onblockconstructs in the manager playbooks.
The custom
osism-fqcnansible-lint rule previously emitted spuriousviolations on
block/rescue/alwaysconstructs, so these annotationswere added as a workaround. osism/container-images#902 fixes the rule to
correctly skip these constructs, and the updated
ansible-lintimage hasbeen published (and is consumed as
:latestby the Zuul lint job), so thesuppressions are no longer needed.
Both suppressions sat on genuine block false-positives:
ansible/manager-part-0.yml— "Debian/Ubuntu specific tasks" blockansible/manager-part-3.yml— "Try to apply the manager role" blockNote: osism/issues#1368 listed
manager-part-1.yml, but that file has noosism-fqcnannotation. The actual second annotation lives inmanager-part-3.yml(written as# noqa osism-fqcn, without the colon).The issue checklist has been corrected accordingly.
Related-Bug: #1368