This repository was archived by the owner on Aug 20, 2024. It is now read-only.
Syncing needed submodules - #41
Open
kenfred wants to merge 5 commits into
Open
Conversation
Adding qtrepotool subrepo. The build instructuctions say it should be there if building directly from a git checkout (http://doc.qt.io/qt-5/windows-building.html). PATH was being appended with qtrepotools/bin, but that directory doesn't exist without updating the submodule. Adding qtdeclarative subrepo. QtCreator won't allow the resulting Qt package to be in a kit unless qmlscene.exe is present, which is built in qtdeclarative.
Can't modify dictionary during iteration
Fixing windows call to configure.bat
|
qtdeclarative should definitively be added in the options, but not be mandatory. |
Author
|
Ok, I'll make qtdeclarative an option. Having qtrepotools didn't seem to make a difference in the configurations I tried. However, it is clearly stated as being necessary in the build instructions. The recipe was already referencing the bin directory, just not ensuring the bin directory existed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding qtrepotool subrepo. The build instructuctions say it should be there if building directly from a git checkout (http://doc.qt.io/qt-5/windows-building.html). PATH was being appended with qtrepotools/bin, but that directory doesn't exist without updating the submodule.
Adding qtdeclarative subrepo. QtCreator won't allow the resulting Qt package to be in a kit unless qmlscene.exe is present, which is built in qtdeclarative.