Skip to content

fix(judge): make ltp judge robust against log pollution and duplicate summaries #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Freefor100 wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −2
Open

fix(judge): make ltp judge robust against log pollution and duplicate summaries #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion kernel/judge/judge_ltp-glibc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import re
import sys
import json

Expand Down Expand Up @@ -42,13 +43,16 @@ def parse_ltp_log(content):
current_case = None
return_code = None
in_summary = False
skip_summary = False

for line in lines:
line = re.sub(r'\x1b\[[0-9;]*m', '', line) # strip ANSI color codes so kernel log pollution doesn't crash the judge
stripped_line = line.strip()

if stripped_line.startswith('RUN LTP CASE'):
current_case = stripped_line.split()[-1]
summary_data = {'passed': 0, 'failed': 0, 'broken': 0, 'skipped': 0, 'warnings': 0, 'all': 0}
summary_seen = False
return_code = None
in_summary = False

Expand All @@ -71,17 +75,27 @@ def parse_ltp_log(content):
elif current_case:
if stripped_line == 'Summary:':
in_summary = True
if summary_seen:
skip_summary = True
continue
summary_seen = True
skip_summary = False
continue

if in_summary:
if not stripped_line:
in_summary = False
continue
if skip_summary:
continue

parts = stripped_line.split()
if len(parts) >= 2 and parts[0] in ['passed', 'failed', 'broken', 'skipped', 'warnings']:
key = parts[0]
value = int(parts[1])
m = re.match(r'\d+', parts[1])
if m is None:
continue # line polluted by interleaved kernel log, skip instead of crash
value = int(m.group())
summary_data[key] += value
summary_data['all'] += value

Expand Down
16 changes: 15 additions & 1 deletion kernel/judge/judge_ltp-musl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import re
import sys
import json

Expand Down Expand Up @@ -42,13 +43,16 @@ def parse_ltp_log(content):
current_case = None
return_code = None
in_summary = False
skip_summary = False

for line in lines:
line = re.sub(r'\x1b\[[0-9;]*m', '', line) # strip ANSI color codes so kernel log pollution doesn't crash the judge
stripped_line = line.strip()

if stripped_line.startswith('RUN LTP CASE'):
current_case = stripped_line.split()[-1]
summary_data = {'passed': 0, 'failed': 0, 'broken': 0, 'skipped': 0, 'warnings': 0, 'all': 0}
summary_seen = False
return_code = None
in_summary = False

Expand All @@ -71,17 +75,27 @@ def parse_ltp_log(content):
elif current_case:
if stripped_line == 'Summary:':
in_summary = True
if summary_seen:
skip_summary = True
continue
summary_seen = True
skip_summary = False
continue

if in_summary:
if not stripped_line:
in_summary = False
continue
if skip_summary:
continue

parts = stripped_line.split()
if len(parts) >= 2 and parts[0] in ['passed', 'failed', 'broken', 'skipped', 'warnings']:
key = parts[0]
value = int(parts[1])
m = re.match(r'\d+', parts[1])
if m is None:
continue # line polluted by interleaved kernel log, skip instead of crash
value = int(m.group())
summary_data[key] += value
summary_data['all'] += value

Expand Down