Improve CI and Cargo workspace#5
Open
sermuns wants to merge 4 commits into
Open
Conversation
…-toolchain` It is more popular. 1.5k stars as opposed to ~400 stars.
Resolver v3 doesn't seem supported on Rust 1.82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
dtolnay/rust-toolchaininstead ofactions-rust-lang/setup-rust-toolchainIt is simply the more popular choice. @dtolnay is a very trusted member of the Rust ecosystem.
Do caching in GitHub workflows
I think it's unnecessary to compile dependencies every workflow run. Adding caching saves time and resources.
Use workspace resolver v3 andglobexamples/*No reason not to use the latest resolver and automatically glob examples!We can glob
examples/*as workspace members. I also thought we could use workspace resolver v3, but that doesn't seem to be supported on 1.82 toolchain!