Conversation
The Release workflow triggered on `pull_request: closed [release]`, so its jobs
ran in the PR-merge ref context (refs/pull/N/merge). The github-pages
environment only allows deployments from the `main`/`release` branches, so the
deploy was always rejected ("Branch refs/pull/N/merge is not allowed to deploy
to github-pages"). The workflow had in fact never deployed successfully.
Follow the official VitePress GitHub Pages guide: trigger on `push` to the
release branch (plus workflow_dispatch). The run then executes in the `release`
branch context, which is now an allowed deployment branch for the github-pages
environment, so deploy-pages succeeds.
Also drop the `if: github.event.pull_request.merged == true` guards on all three
jobs (obsolete once the trigger is push/dispatch rather than pull_request).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Fix GitHub Pages deploy: Release workflow never deploys
github-actions
Bot
added
the
ci-testing
github-actions
Bot
changed the title
github-actions
Bot
added
the
release-candidate
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the updated Release workflow to run in the release branch context so GitHub Pages deployments are allowed by the github-pages environment protection rules, enabling the handbook (including /style-guide) to publish correctly from release.
Changes:
- Switch Release workflow trigger from
pull_request: closed(merge ref) topushonrelease(branch ref). - Remove obsolete
if: github.event.pull_request.merged == truejob guards now that the workflow no longer runs on PR events.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Target
Promote
main→releaseto publish the Coding Style Guide and activate thefixed GitHub Pages deploy.
Contents (already reviewed/merged on
main):templates — Add Coding Style Guide (TypeScript, Go, Python) + shared config templates #73
pushtoreleasesodeploy-pagesruns in an allowed environment context — Fix GitHub Pages deploy: Release workflow never deploys #77 / Fix GitHub Pages deploy: Release workflow never deploys #762. Specification / Test Plan
Merging this PR is a
pushtorelease. The pushed commit carries the fixedrelease.yml(on: push: branches:[release]), so the Release workflow triggers,builds VitePress, and deploys to GitHub Pages from the
releasecontext — now anallowed deployment branch for the
github-pagesenvironment.Verify after merge:
/style-guide, currently 404).3. Notes for Shipping
First successful run of the release→Pages pipeline. If deploy still reports an
environment rejection, confirm
releaseis in thegithub-pagesenvironment'sallowed deployment branches (it was added in settings).