fix: bump scans backend, orm, and database pins - #123
Open
spencer-osbrjp wants to merge 1 commit into
Open
Conversation
BumpRegistry enumerated option groups in an ad-hoc slice that omitted backend/orm/database, silently freezing those pins out of the pinned-channel freshness policy. The slice moves to Registry.optionGroups() and a reflection test asserts it covers every []OptionEntry field of the struct, so a future category can't be forgotten again. Closes #122 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122
BumpRegistry's ad-hoc group slice omittedBackend,ORM, andDatabase, sobungkus-cli bumpnever refreshed those pins (hono, drizzle-orm, pg, ...).Registry.optionGroups(), now covering all 16[]OptionEntrycategories.TestBumpRegistryScansBackendOrmDatabasepins the three previously-frozen categories end to end.TestOptionGroupsCoverRegistryreflects over theRegistrystruct and fails if any[]OptionEntryfield is missing fromoptionGroups()— the class-level guard the issue asked for, so a future category can't silently fall out of the freshness policy.go test -count=1 ./...green.🤖 Generated with Claude Code