Fix earlier CheckLoginIframe change - #118
Merged
amazy merged 1 commit intoAug 28, 2026
Merged
Conversation
was incorrect. My intention was to fall back to a `true` value if keycloackConfig['CheckLoginIframe'] is not set but the expression ``` keycloackConfig['CheckLoginIframe'] || true ``` always evaluates to true. *Facepalm* I removed || true part altogether because I realised that a value will always be set by DefaultConfiguration.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, this is embarrassing.
The change in #116 was incorrect. My intention was to fall back to a
truevalue ifkeycloackConfig['CheckLoginIframe']is not set but the expressionalways evaluates to true . Facepalm
I removed the
|| truepart altogether because I realised that a value will always be set by DefaultConfiguration.json.I said in the previous PR that I confirmed it working. That is because I was testing in Chrome incognito windows and for some reason the iframe gets removed from the DOM in an incognito window so my change seemed to be working.
It does work as expected now.