Skip to content

🔒 Fix Command Injection in bs2system #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orpheus497 merged 2 commits into from
Jun 5, 2026
Merged

🔒 Fix Command Injection in bs2system #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8984dff
🔒 Fix Command Injection in bs2system
google-labs-jules[bot] Jun 5, 2026
ff84153
🔒 Fix Command Injection in bs2system
google-labs-jules[bot] Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tc.os.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,21 @@ bs2cmdlist(char *str)
}
if (strlen(str_beg) != 0)
{
const char *p;
int sq = 0, dq = 0;

for (p = str_beg; *p != '\0'; p++)
{
if (*p == '\'' && !dq)
sq = !sq;
else if (*p == '"' && !sq)
dq = !dq;
else if (!sq && !dq && strchr("&|<>$\140\n\r", *p) != NULL)
{
stderror(ERR_NAME | ERR_STRING, "unsafe character in command");
return -1;
}
}
ret = bs2system(str_beg);
flush();
if (ret != 0 /*&& !option.err_ignore*/)
Expand Down
Loading