Fix: steal box not working properly#9
Merged
Merged
Conversation
ormai
added a commit
that referenced
this pull request
Sep 17, 2025
Fix: steal box not working properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When two or more bombs had the same timer value and exploded in the same turn, only the ones still present in
self.bombswere considered for propagation. This happened because exploded bombs were already removed fromself.bombsduringself.tick_bombs().As a result, in
self.propagate_explosions(), the following loop:would miss bombs that had already exploded in the same turn, even though they could still block the explosion chain. This led to explosions incorrectly continuing beyond those bombs, violating the intended behavior.
Test coverage
This fix addresses cases like the
test_bomb_steals_box, where two bombs explode in the same turn, one triggering the other. Previously, one bomb could remain incorrectly inself.bombs, or explosions could pass through exploded bombs. After this fix, both bombs are properly removed and propagation behaves as expected.