fix: remove symbology from legend for secure layers - #2329
Open
steff-o wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2290
No new configuration.
Symbology in the legend for secure layers is replaced with empty symbol (No legend available) to avoid potential calls to the server which may deny the request. The symbology setting of the layer itself is not affected in order to not mess too much up if someone implements a way to "unsecure" a layer without reloading the map.
A more fine grained approach could have been implemented that only avoid symbols using calls to getLegendGraphics, which is the most common problem with secure layers, but since the layer is not visible anyway there is no reason to display symbology even if client side symbology would be possible to display. This allows for a cleaner less layer dependent implementation.
If a secure layer has StylePicker, the StylePicker is not displayed for same reason as above.
PrintLegend is not affected as it only creates legend for visible layers and secure layers are not visible.