Ratty camera protocol#118
Conversation
Add an RGP extension to support controlling the camera Remove unused parameters
orhun
left a comment
There was a problem hiding this comment.
thanks for the PR! I have pushed a cleanup commit and have a small question about one of the parts :)
|
Hey hey! I just fixed conflicts and gave this a try - but I'm not sure if it works as expected. Do you mind giving this a try with the latest changes here? |
|
Sure! Can you confirm if it worked before the merge conflict resolution? Just to have another data point |
|
Hmm maybe I broke it 😅 |
|
Yep, I can confirm latest commit is broken for me too, but it works before the changes |
|
okay I just ran this from your previous commits and got an idea how the feature should look like. I think something broke while fixing the conflicts, any chance that you could take a look or reimplement this? |
|
Sure, I'll have a look! |
|
Yeah uhhhh, I'm having trouble merging in a bug-free manner too 😭 hard to believe the branch could've gone stale this quickly, I'll do a more in depth investigation |
Hey!
Ctrl + Alt + O -> Regular orthographic view
Ctrl + Alt + P -> New perspective view ('videogame camera' style)
Basically, both cameras are created at startup, but only the requested one is activated in Bevy. Not sure if this might suppose a performance penalty. I am also not an expert in Rust nor Bevy, so sorry if something's improvable 😅. I also refactored a bunch of
matchstatements into comparisons againstis_3d()where I thought it might be reasonable, since 3 long enum values per arm seemed silly once I added the newPersp3dmode (I can revert this if needed).Additionally:
The ratty graphics protocol is expanded as per the update to
protocols/graphics.md, with the corresponding implementation. The rendering and input processing pipeline is reordered in order to allow the applications and the user to control the camera at once harmoniously. I am not a Rust expert, and would, in general, appreciate feedback on the architecture and style.Missing: better documentation of the code, add support for the features described here to the big rat demo, and perhaps add
Ctrl+Alt+[0-9]bindings for manually changing to the 10 camera slots.Obsoletes #89 and implements #114