This repository was archived by the owner on Sep 30, 2023. It is now read-only.
Added applyEntry function to Index. - #46
Open
CSDUMMI wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented this function because I want it to be easier to customize validation
of entries without modifying or knowing about the internal data structure used
in the KVStore.
If this PR is merged I plan on implementing similar functions on the DocStore, FeedStore and EventLog.
I think it is important for OrbitDB to be easily customizable and this feature should
lower the effort for customizing validation significantly.
In it's current form, the
applyEntryfunction is not a breaking change, but an addedpattern that can be used to ease the customization efforts of Stores.
If this pattern is implemented I also feel ready to finally finish Part 5 of the Field Manual by introducing this pattern and implementing moderation rules using it.
Thanks for your consideration!
Custom Validation of Entries on the KeyValueIndex
To create a custom validation of the Index using the
applyEntryfunction: