feat(settings): redesign settings panel as a tabbed/sidebar layout#181
Merged
Conversation
Restructure the single overflowing column into a macOS-style dialog with a left category nav (Appearance / Editor / Files / Shortcuts / Advanced) and a scrollable content pane. - Fix the dialog overflowing the viewport: sticky header + scrollable body + sticky footer, capped at max-h-[88vh]. - Group the 12 settings into five labelled categories. - Replace raw checkboxes + "On/Off" text with accessible toggle switches (role="switch"); move each hint to a description subtitle under the label. - Wire the panel through new .mk-settings-* / .mk-toggle classes using --mk-* tokens so it tracks light/dark/sepia (the old dark: utilities silently missed sepia). Primary "Done" is now an accent button. - Refit ShortcutsEditor to live inside its own tab (drop standalone title and top border, token-style the filter, give the list more height). - Add catAppearance/catEditor/catFiles/catAdvanced/close i18n keys (en + zh). Inactive tabs stay mounted (hidden) so drafted state and existing tests hold. 1005/1005 unit tests pass; tsc -b and biome clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The Settings dialog was a single, ungrouped column that overflowed the viewport — the title and the
Restore defaults / Donefooter were clipped on shorter screens (visible in the original screenshot). This reworks it into a macOS-style tabbed / sidebar dialog.Changes
flexcolumn with a sticky header, a scrollable content pane, and a sticky footer, capped atmax-h-[88vh].role="switch",aria-checked); each hint moves to a description subtitle under the label..mk-settings-*/.mk-toggleclasses using--mk-*variables, so it now tracks light / dark / sepia (the previousdark:utilities never fired underhtml.theme-sepia). PrimaryDoneis now an accent-filled button.catAppearance/catEditor/catFiles/catAdvanced/closei18n keys toen+zh.Inactive tabs stay mounted (hidden), so drafted state survives tab switches and existing cross-category tests keep passing. Behavior is otherwise unchanged: live-apply on change, backdrop-click / Done to close, Restore defaults.
Testing
pnpm test→ 1005/1005 unit tests pass (incl.SettingsDialog+ShortcutsEditorsuites)tsc -b→ cleanbiome check→ clean🤖 Generated with Claude Code